Skip to content

PR for a next 0.68.x release#2067

Open
AndrewChubatiuk wants to merge 21 commits into
release-0.68from
release-0.68-next
Open

PR for a next 0.68.x release#2067
AndrewChubatiuk wants to merge 21 commits into
release-0.68from
release-0.68-next

Conversation

@AndrewChubatiuk
Copy link
Copy Markdown
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Apr 16, 2026

Summary by cubic

Improves volume handling and reconciliation reliability: existing volumes are reused by name, parsing errors moved to Status and set to Failed, retryable errors now requeue to avoid getting stuck in Expanding, and OpenShift OLM publishing is migrated to FBC with opm validation and an updated OperatorHub release flow.

  • New Features

    • Added controllers to convert Prometheus ServiceMonitor, PodMonitor, Probe, PrometheusRule, ScrapeConfig, and AlertmanagerConfig into VM CRs.
    • Unified reconcile error handler across controllers: parsing errors set status to Failed; metrics recorded for parsing/get/conflict errors; retryable errors requeue.
    • Migrated OpenShift bundles to File-based Catalog (FBC): generate catalog/latest/catalog.yaml, validate with opm; OperatorHub workflow pulls artifacts from release.yaml and uses __operatorhub-repo.
  • Bug Fixes

    • Reuse existing volumes by name for data/cache paths across vmagent, vmcluster/vtcluster/vlcluster components, VLAgent, VMAnomaly, and VMAlertmanager.
    • StorageSpec.IntoSTSVolume now errors on conflicts and skips creating PVCs/volumes when a same-named volume exists; StorageVolumeMountsTo skips adding volumes in StatefulSet mode (with tests).
    • VMBackup/VMRestore: added acceptEULA; -eula no longer set by default; ExtraArgs supports flags without values.
    • Fixed additional Service generation for VMCluster/VLCluster/VTCluster when useAsDefault: false.
    • Improved shard scaling logs for VMAgent.

Internals switch to Kubernetes sets and aggregate errors; default VM app versions are bumped (metrics v1.143.0, logs v1.50.0, anomaly v1.29.3); VMDistributed defaults write load balancing to least_loaded; Go builder upgraded to 1.25.10.

Written for commit 6326c19. Summary will update on new commits.

…2066)

* vmagent/vmcluster/vlcluster/vtcluster/vlagent/vmanomaly/vmalertmanager: use existing volume if it's name matches sts volume claim template

* chore: fetch volume quicker

* test: add tests for StorageVolumeMountsTo

---------

Co-authored-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 16 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:16">
P2: Custom agent: **Changelog Review Agent**

This entry is an implementation detail that only affects users who name a volume `persistent-queue-data`, so it doesn’t meet the rule’s “majority of users” requirement for changelog entries. Remove it from the changelog.</violation>

<violation number="2" location="docs/CHANGELOG.md:17">
P2: Custom agent: **Changelog Review Agent**

This entry documents a narrow volume-name handling change that only applies to users with `vmstorage-db`/`vmselect-cachedir` volumes, which violates the rule that changelog items must affect the majority of users. Remove it from the changelog.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread docs/CHANGELOG.md
Comment thread docs/CHANGELOG.md
AndrewChubatiuk and others added 4 commits April 17, 2026 10:59
…2036)

* reconcile: properly handle parsing and get errors for prom objects

* test: add tests for ReconcileErrWithStatus

---------

Co-authored-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
* test: run upgrade test every time

* reuse e2e target

---------

Co-authored-by: Andrii Chubatiuk <andrew.chubatiuk@gmail.com>
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 issues found across 35 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:16">
P2: Fix the malformed VMSingle example value (`true"`) in the update note; it should be `true`.</violation>

<violation number="2" location="docs/CHANGELOG.md:16">
P1: Custom agent: **Changelog Review Agent**

This new changelog entry does not follow the mandatory format (must start with FEATURE/BUGFIX/SECURITY and include affected services plus references).</violation>
</file>

<file name="internal/controller/operator/controllers.go">

<violation number="1" location="internal/controller/operator/controllers.go:145">
P1: Using a concrete type switch on `err` breaks handling for wrapped `*getError`/`*parsingError`; use `errors.As` so wrapped errors still trigger NotFound handling and metrics paths.</violation>
</file>

<file name="internal/controller/operator/promalertmanagerconfig_controller.go">

<violation number="1" location="internal/controller/operator/promalertmanagerconfig_controller.go:88">
P3: The error log message references the wrong resource type (`VMPodScrape`), which makes troubleshooting reconciliation failures misleading.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread internal/controller/operator/controllers.go
Comment thread docs/CHANGELOG.md Outdated
Comment thread docs/CHANGELOG.md Outdated
Comment thread internal/controller/operator/promalertmanagerconfig_controller.go Outdated
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:20">
P1: Custom agent: **Changelog Review Agent**

These changelog entries violate mandatory structure requirements: they omit the required before/now user-impact explanation and contain no issue/PR references (rule sections 3 and 4).</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread docs/CHANGELOG.md
@AndrewChubatiuk AndrewChubatiuk force-pushed the release-0.68-next branch 3 times, most recently from 7100a57 to 0166ecf Compare April 17, 2026 13:15
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 8 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/operatorhub.yaml">

<violation number="1" location=".github/workflows/operatorhub.yaml:63">
P1: Verify the downloaded `opm` binary checksum before installing it; the current step executes unverified remote content.</violation>

<violation number="2" location=".github/workflows/operatorhub.yaml:75">
P1: Initialize `PREV_CATALOG` to a valid default before conditional assignment; it is currently used unconditionally and can break the workflow when no prior catalog exists.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread .github/workflows/operatorhub.yaml Outdated
Comment thread .github/workflows/operatorhub.yaml Outdated
Instead of storing errors as strings and joining them use k8s apimachinery's `errors.NewAggregate`
@vrutkovs vrutkovs force-pushed the release-0.68-next branch from a2d452f to 534ef26 Compare April 22, 2026 09:25
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:22">
P2: Custom agent: **Changelog Review Agent**

New tip changelog entry is missing mandatory issue/PR reference links required by the changelog structure rule.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread docs/CHANGELOG.md
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:18">
P2: Custom agent: **Changelog Review Agent**

SECURITY changelog entries must list the affected services; this one only states the Go builder upgrade and omits any impacted service/component.</violation>
</file>

Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic

Comment thread docs/CHANGELOG.md
makasim and others added 6 commits May 14, 2026 20:53
…al-service when useAsDefault: false (#2137)

Signed-off-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
Co-authored-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
Signed-off-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
Co-authored-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants