PR for a next 0.68.x release#2067
Conversation
…2066) * vmagent/vmcluster/vlcluster/vtcluster/vlagent/vmanomaly/vmalertmanager: use existing volume if it's name matches sts volume claim template * chore: fetch volume quicker * test: add tests for StorageVolumeMountsTo --------- Co-authored-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
There was a problem hiding this comment.
2 issues found across 16 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/CHANGELOG.md">
<violation number="1" location="docs/CHANGELOG.md:16">
P2: Custom agent: **Changelog Review Agent**
This entry is an implementation detail that only affects users who name a volume `persistent-queue-data`, so it doesn’t meet the rule’s “majority of users” requirement for changelog entries. Remove it from the changelog.</violation>
<violation number="2" location="docs/CHANGELOG.md:17">
P2: Custom agent: **Changelog Review Agent**
This entry documents a narrow volume-name handling change that only applies to users with `vmstorage-db`/`vmselect-cachedir` volumes, which violates the rule that changelog items must affect the majority of users. Remove it from the changelog.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
…2036) * reconcile: properly handle parsing and get errors for prom objects * test: add tests for ReconcileErrWithStatus --------- Co-authored-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
* test: run upgrade test every time * reuse e2e target --------- Co-authored-by: Andrii Chubatiuk <andrew.chubatiuk@gmail.com>
There was a problem hiding this comment.
4 issues found across 35 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/CHANGELOG.md">
<violation number="1" location="docs/CHANGELOG.md:16">
P2: Fix the malformed VMSingle example value (`true"`) in the update note; it should be `true`.</violation>
<violation number="2" location="docs/CHANGELOG.md:16">
P1: Custom agent: **Changelog Review Agent**
This new changelog entry does not follow the mandatory format (must start with FEATURE/BUGFIX/SECURITY and include affected services plus references).</violation>
</file>
<file name="internal/controller/operator/controllers.go">
<violation number="1" location="internal/controller/operator/controllers.go:145">
P1: Using a concrete type switch on `err` breaks handling for wrapped `*getError`/`*parsingError`; use `errors.As` so wrapped errors still trigger NotFound handling and metrics paths.</violation>
</file>
<file name="internal/controller/operator/promalertmanagerconfig_controller.go">
<violation number="1" location="internal/controller/operator/promalertmanagerconfig_controller.go:88">
P3: The error log message references the wrong resource type (`VMPodScrape`), which makes troubleshooting reconciliation failures misleading.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/CHANGELOG.md">
<violation number="1" location="docs/CHANGELOG.md:20">
P1: Custom agent: **Changelog Review Agent**
These changelog entries violate mandatory structure requirements: they omit the required before/now user-impact explanation and contain no issue/PR references (rule sections 3 and 4).</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
7100a57 to
0166ecf
Compare
0166ecf to
283f3a9
Compare
There was a problem hiding this comment.
2 issues found across 8 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/operatorhub.yaml">
<violation number="1" location=".github/workflows/operatorhub.yaml:63">
P1: Verify the downloaded `opm` binary checksum before installing it; the current step executes unverified remote content.</violation>
<violation number="2" location=".github/workflows/operatorhub.yaml:75">
P1: Initialize `PREV_CATALOG` to a valid default before conditional assignment; it is currently used unconditionally and can break the workflow when no prior catalog exists.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
Instead of storing errors as strings and joining them use k8s apimachinery's `errors.NewAggregate`
a2d452f to
534ef26
Compare
…om first_available to least_loaded (#2099)
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/CHANGELOG.md">
<violation number="1" location="docs/CHANGELOG.md:22">
P2: Custom agent: **Changelog Review Agent**
New tip changelog entry is missing mandatory issue/PR reference links required by the changelog structure rule.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/CHANGELOG.md">
<violation number="1" location="docs/CHANGELOG.md:18">
P2: Custom agent: **Changelog Review Agent**
SECURITY changelog entries must list the affected services; this one only states the Go builder upgrade and omits any impacted service/component.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic
Changelog [v1.141.0](https://github.com/VictoriaMetrics/VictoriaMetrics/blob/master/docs/victoriametrics/changelog/CHANGELOG.md#v11410) Signed-off-by: Max Kotliar <mkotlyar@victoriametrics.com>
…al-service when useAsDefault: false (#2137) Signed-off-by: Vadim Rutkovsky <vadim@vrutkovs.eu> Co-authored-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
Signed-off-by: Vadim Rutkovsky <vadim@vrutkovs.eu> Co-authored-by: Vadim Rutkovsky <vadim@vrutkovs.eu>
Changelog [v1.143.0](https://github.com/VictoriaMetrics/VictoriaMetrics/blob/master/docs/victoriametrics/changelog/CHANGELOG.md#v11430) Signed-off-by: f41gh7 <nik@victoriametrics.com>
* tests: add more reconcile status change e2e tests * fix: nitpick in status update logic
Summary by cubic
Improves volume handling and reconciliation reliability: existing volumes are reused by name, parsing errors moved to Status and set to Failed, retryable errors now requeue to avoid getting stuck in Expanding, and OpenShift OLM publishing is migrated to FBC with
opmvalidation and an updated OperatorHub release flow.New Features
catalog/latest/catalog.yaml, validate withopm; OperatorHub workflow pulls artifacts fromrelease.yamland uses__operatorhub-repo.Bug Fixes
StorageSpec.IntoSTSVolumenow errors on conflicts and skips creating PVCs/volumes when a same-named volume exists;StorageVolumeMountsToskips adding volumes in StatefulSet mode (with tests).acceptEULA;-eulano longer set by default;ExtraArgssupports flags without values.useAsDefault: false.Internals switch to Kubernetes
setsand aggregate errors; default VM app versions are bumped (metrics v1.143.0, logs v1.50.0, anomaly v1.29.3);VMDistributeddefaults write load balancing to least_loaded; Go builder upgraded to 1.25.10.Written for commit 6326c19. Summary will update on new commits.